Skip to content

Added missing dry-run check for docker stop #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quack6765 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added missing dry-run check for docker stop #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Unraid Auto Dataset Watcher & Converter v2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,11 @@ stop_docker_containers() {
done <<< "$bindmounts" # send bindmounts into the loop

if [ "$stop_container" = true ]; then
docker stop "$container"
if [ "$dry_run" != "yes" ]; then
docker stop "$container_name"
else
echo "Dry Run: Docker container $container_name would be stopped"
fi
stopped_containers+=("$container_name")
else
echo "Container ${container_name} is not required to be stopped as it is already a separate dataset."
Expand Down