Merged
Conversation
ChengaDev
reviewed
Dec 2, 2024
ChengaDev
approved these changes
Dec 3, 2024
eladbash
reviewed
Dec 23, 2024
eladbash
reviewed
Dec 23, 2024
examples/lambda-in-vpc.tf
Outdated
|
|
||
| env_vars = { | ||
| # Required environment variables | ||
| SPECTRAL_DSN = "MySpectralDSN" |
Member
There was a problem hiding this comment.
I think better avoid spectral dsn in the examples - the best practice is to use vault since this is a secret
eladbash
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support VPC to lambda.
After this change, you can add VPC configuration to lambda and it will add the policy.