-
Notifications
You must be signed in to change notification settings - Fork 39
Add search_user Action
#91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search_user Action
#91
Conversation
This PR includes the `search_users` action.
57f3d41 to
bbdafb8
Compare
|
@cognifloyd @floatingstatic 👋 Just a bump about review of this one. |
actions/search_users.yaml
Outdated
| include_active: | ||
| type: boolean | ||
| description: True to include active users. | ||
| required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to make include_active and include_inactive required here? It seems you have defaults both in the yaml params here as well as in run().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, they aren't required. Let me update that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made them match the defaults for the underlying method called. 👍
CHANGES.md
Outdated
| ## 3.2.3 | ||
| - Addresses [#87](https://github.com/StackStorm-Exchange/stackstorm-jira/issues/87) JIRA sensor failure due to [deprecation of /v2/search endpoint](https://developer.atlassian.com/changelog/#CHANGE-2046) | ||
|
|
||
| # 3.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpavlav sorry one more thing i just noticed before I was about to merge... somehow 3.3.0 falls after 3.2.3 in the changelog. Can you please fix? Otherwise lgtm
This PR includes the
search_usersaction.Example execution: