Merged
Conversation
blag
suggested changes
Dec 7, 2020
Contributor
blag
left a comment
There was a problem hiding this comment.
One thing to fix, but otherwise looks good. Thanks!
amanda11
reviewed
Dec 7, 2020
Contributor
amanda11
left a comment
There was a problem hiding this comment.
I had no comments on top of those already given.
I wasn't sure if python-virtualenv or python3.6-virtualenv was required.
Co-authored-by: blag <blag@users.noreply.github.com>
Member
Author
blag
approved these changes
Dec 7, 2020
Contributor
|
We should update our dh-virtualenv fork from We are 150 commits behind and But that's separate from this. |
Contributor
|
Upstreamed our changes to spotify/dh-virtualenv#317. |
Member
Author
|
@blag Nice one! 💯 |
This was referenced Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install python 3.6 and development packages for Ubuntu Xenial from Deadsnakes PPA (https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa) so we could build the U16 st2 deb/rpm packages relying on py3.
Ubuntu Xenial gotchas, to be careful:
Interesting Deadsnakes PPA notes: