feat: Name and Tag of latest release in repository by URL#10
Open
feat: Name and Tag of latest release in repository by URL#10
Conversation
stan-osipov
requested changes
Mar 24, 2021
Contributor
stan-osipov
left a comment
There was a problem hiding this comment.
Please document public API points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature description
Using the link to GitHub repo, gets a name and a tag of a latest release.
Concerns
GitHubRelease request is not async, because UnityWebRequest is allowed to be created and to start exceptionally from the main thread. I don't know if there is some reasonable workaround for this limitation.
Adding a dependency on NewtonSoft.Json seemed unnecessary for finding 2 values in the json string, so for now I avoided it.
Test
To test the feature, you can use following script: