This repository was archived by the owner on Sep 16, 2025. It is now read-only.
feat: improve Relocation & Utilities
#302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: * add second template arg to applicable `Relocation::write_` funcs for address offset * remove `AllocTrampoline` from `stl::write_*` funcs, this is bad practice * normalize `stl::write_*` support for structs with `std::uintptr_t`, `REL::ID`, `REL::Offset`, `REL::Relocation<std::uintptr_t>` static `address` members
Contributor
|
I was hoping the stl stuff would be deprioritized in favor of just adding it to Relocation (where applicable) |
Contributor
Author
|
So I agree, but I don't think it would be applicable in this case. The |
ThirdEyeSqueegee
merged commit 417c17a
into
Starfield-Reverse-Engineering:main
5 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
Relocation::write_funcs for address offsetAllocTrampolinefromstl::write_*funcs, this is bad practicestl::write_*support for structs withstd::uintptr_t,REL::ID,REL::Offset,REL::Relocation<std::uintptr_t>staticaddressmembers