feat: add Dota Stats plugin

[BambooFury]

Add dotastats plugin as a submodule.

Submodule: plugins/dotastats
URL: https://github.com/BambooFury/Dota-Stats.git

[BambooFury]

up

[shdwmtr]

We won't be adding any new plugins until Lua support is released. As described in the discord and the plugin template, we are moving from Python backends to Lua. Unfortunately, there is no benefit of accepting a Python plugin right now if it will just have to be ported to Lua right after.

[BambooFury]

There is a prime time so that I can make new plugins and add this?

[shdwmtr]

I don't understand

[BambooFury]

Sorry, I don't know English very well. I wanted to ask when there will be a transition to Lua so I can add my Dotastats plugin.

[jcdoll]

Hi BambooFury -
Fellow plugin author and Dota enjoyer here :).

The Lua transition is done from what I can tell. I just released a plugin in Lua a few days ago. After initially writing the backend in python I saw this thread and ported my backend to Lua. It's not too bad.

You can use my plugin as a reference in case useful:
https://github.com/jcdoll/hltb-millennium-plugin

Also of course the plugin template, which is also in Lua:
https://github.com/SteamClientHomebrew/PluginTemplate

[BambooFury]

I remade the plugin in Lua.

[shdwmtr]

Your PR adds your repo at 1f263cf which isn't a valid commit.

[shdwmtr]

The plugin is missing a webkit. Check the plugin example.

[BambooFury]

I'll decide everything now

[BambooFury]

Updated the fork and synced with upstream. Webkit is included now. Please review when you have time.

[shdwmtr]

Your setup is still wrong. Check the plugin template, use that as a reference.

[BambooFury]

Updated plugin structure to match PluginTemplate. Ready for review.

[shdwmtr]

https://github.com/BambooFury/Dota-Stats/blob/3b95aab3bb14254c4b436be3bf441f974b44c673/backend/main.lua#L158

This is unsafe, use the http module from Millennium.

[BambooFury]

@shdwmtr Fixed: removed PowerShell/os.execute, removed STRATZ code, moved API calls to webkit fetch(). Ready for review!

[shdwmtr]

Just ensure your plugin build works (from the test build) and then we'll need a third-party to test the plugin test build. Once they've tested it and it works, they can report back here, and I'll merge the plugin. You can find testers in the Millennium discord!

[diemonic1]

I checked and the plugin works fine for me