-
Notifications
You must be signed in to change notification settings - Fork 151
Adding ProtonDB Badges eXtended plugin #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ProtonDB Badges eXtended plugin #943
Conversation
Issues Found
Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
|
@bschelst Are you open to making the following changes?
|
ed09fbc to
f12705c
Compare
f12705c to
8dc3602
Compare
|
@OMGDuke : Thanks. |
8dc3602 to
6afc0df
Compare
|
Code all LGTM, gonna just ask for a second review just to make sure all the submodule changing stuff is 👌 |
EMERALD0874
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for testing
|
@bschelst Please generate an accurate pnpm-lock.yaml file so we can run the build pipeline. |
6afc0df to
3444f92
Compare
Hi, Done. |
|
Please rebase from main so you aren't building other plugins in the pipeline, as well. |
3444f92 to
f70c3a8
Compare
Hi, is all OK now? |
Dukeman330
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Appreciate you stepping in to maintain the ProtonDB plugin.
|
@bschelst Perfect! I've deployed to the testing store. @Dukeman330 "Looks good" is not an acceptable testing report nor was the plugin on the testing store at the time of your review. Please only test plugins available on the testing store and use the format on our wiki in your comment: https://wiki.deckbrew.xyz/en/user-guide/testing |
Plugin Testing ReportInstalled PluginsHLTB for Deck - 2.0.4 SpecificationsSteamOS 3.7.17 (Stable) IssuesHas the following major blocking issue(s): None Summary
|
Add protondb-decky-eXtended to Plugin Store
ProtonDB Badges eXtended retrieves ProtonDB ratings via the ProtonDB API and overlays them as a tappable badge on each game’s library page & store. Tapping the badge opens the corresponding ProtonDB page.
This plugin is an actively maintained, fork of the original protondb-decky plugin, which is archived/not maintained anymore.
Compared to the original/archived protondb-decky plugin:
Examples:
Task Checklist
Developer
Plugin
Backend
Community
Testing