Skip to content

2022 (Sourcery refactored) #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sourcery-ai wants to merge 1 commit into from
Closed

2022 (Sourcery refactored) #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 16 additions & 31 deletions y_2022/day8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,32 +21,21 @@ def is_visible(self, i):
if i[1] in [0, self.max_h - 1]:
return True

# visible from Top
visible_Top = True
for j in range(0, i[0]):
if self.__grid[(j, i[1])] >= self.__grid[(i)]:
visible_Top = False

# visible from Left
visible_Left = True
for j in range(0, i[1]):
if self.__grid[(i[0], j)] >= self.__grid[(i)]:
visible_Left = False

# visible from Bottom
visible_Bottom = True
for j in range(i[0] + 1, self.max_h):
if self.__grid[(j, i[1])] >= self.__grid[(i)]:
visible_Bottom = False

# visible from Right
visible_Right = True
for j in range(i[1] + 1, self.max_w):
if self.__grid[(i[0], j)] >= self.__grid[(i)]:
visible_Right = False

is_visible = visible_Top or visible_Left or visible_Bottom or visible_Right
return is_visible
visible_Top = all(
self.__grid[(j, i[1])] < self.__grid[(i)] for j in range(i[0])
)
visible_Left = all(
self.__grid[(i[0], j)] < self.__grid[(i)] for j in range(i[1])
)
visible_Bottom = all(
self.__grid[(j, i[1])] < self.__grid[(i)]
for j in range(i[0] + 1, self.max_h)
)
visible_Right = all(
self.__grid[(i[0], j)] < self.__grid[(i)]
for j in range(i[1] + 1, self.max_w)
)
return visible_Top or visible_Left or visible_Bottom or visible_Right
Comment on lines -24 to +38
Copy link
Contributor Author

@sourcery-ai sourcery-ai bot Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Day.is_visible refactored with the following changes:

This removes the following comments ( why? ):

# visible from Left
# visible from Bottom
# visible from Right
# visible from Top


def viewing_score(self, i):
if i[0] in [0, self.max_w - 1]:
Expand Down Expand Up @@ -85,11 +74,7 @@ def viewing_score(self, i):
return score_Top * score_Left * score_Bottom * score_Right

def _calculate_1(self):
t = 0
for i in self.__grid:
if self.is_visible(i):
t += 1
return t
return sum(bool(self.is_visible(i)) for i in self.__grid)
Comment on lines -88 to +77
Copy link
Contributor Author

@sourcery-ai sourcery-ai bot Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Day._calculate_1 refactored with the following changes:


def _calculate_2(self):
t = 0
Expand Down