Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ name: πŸ§ͺ Test

on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

jobs:
test:
Expand Down
29 changes: 29 additions & 0 deletions rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ crate-type = ["cdylib"]

[dependencies]
# HTTP client with browser impersonation
wreq = { version = "6.0.0-rc.20", default-features = false, features = ["cookies", "json"] }
wreq = { version = "6.0.0-rc.20", default-features = false, features = ["gzip", "deflate", "socks", "cookies", "json", "webpki-roots"] }
wreq-util = "3.0.0-rc.1"

# Neon for Node.js bindings
Expand Down
2 changes: 1 addition & 1 deletion rust/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ pub async fn make_request(options: RequestOptions) -> Result<Response> {
let response = request
.send()
.await
.context("Failed to send request")?;
.with_context(|| format!("{} {}", method, options.url))?;

// Extract response data
let status = response.status().as_u16();
Expand Down
6 changes: 5 additions & 1 deletion rust/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,11 @@ fn request(mut cx: FunctionContext) -> JsResult<JsPromise> {
deferred.settle_with(&channel, move |mut cx| {
match result {
Ok(response) => response_to_js_object(&mut cx, response),
Err(e) => cx.throw_error(format!("Request failed: {}", e)),
Err(e) => {
// Format error with full chain for better debugging
let error_msg = format!("{:#}", e);
cx.throw_error(error_msg)
}
}
});
});
Expand Down
2 changes: 1 addition & 1 deletion src/node-wreq.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export async function request(options: RequestOptions): Promise<Response> {
try {
return await nativeBinding.request(options);
} catch (error) {
throw new RequestError(`Request failed: ${error}`);
throw new RequestError(String(error));
}
}

Expand Down