Conversation
Add a new method in the Walnut::UI namespace (UI.h/UI.cpp). This is a slightly modified version of ButtonCentered that creates left-aligned buttons. It can be useful for popups or other menus where alignment matters.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new method in the Walnut::UI namespace (UI.h/UI.cpp). This is a slightly modified version of ButtonCentered that creates left-aligned buttons. It can be useful for popups or other menus where alignment matters.
Motivation
I originally Added this function because I was creating an application with a popup that required to have a "create" and a "cancel" button. I wanted them to be aligned on the right side for the "create" button and left side for the "cancel". After some tweaking in the ButtonCentered method, I found out that changing the offset coefficient (0.5f to 1.0f) made the button aligned to the left (0.0f would be right). As multiplying by 1.0f can be ignored, I just removed the coefficient and arrived to the following method:
Implementation (UI.cpp)
Use Case