Skip to content

Conversation

@gustavoguimaraes
Copy link
Contributor

Ticket

What does this PR do?

  • Summary:
    Refactor AssertPoster and add tests to it

Breaking changes?

  • Yes:

How can this PR be tested?

Go to shared/arb-contracts/ and run forge test

@linear
Copy link

linear bot commented Apr 4, 2025

SEQ-725 add tests for AssertionPoster.sol

This contract is used for withdrawals, so it needs to be secure

formal verification of the contract would be amazing as well!

https://github.com/SyndicateProtocol/metabased-rollup/blob/main/metabased-translator/contracts/src/AssertionPoster.sol

gustavoguimaraes and others added 4 commits April 4, 2025 16:13
Co-Authored-By: gus@syndicate.io <gus@syndicate.io>
Co-Authored-By: gus@syndicate.io <gus@syndicate.io>
Co-Authored-By: gus@syndicate.io <gus@syndicate.io>
Copy link
Contributor

@tsite tsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Gus!

Copy link
Contributor

@ericvelazquez ericvelazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🙌 Thanks Gus!

@gustavoguimaraes gustavoguimaraes merged commit 41f7392 into main Apr 7, 2025
15 checks passed
@gustavoguimaraes gustavoguimaraes deleted the SEQ-725-Assertion-POster branch April 7, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants