-
Notifications
You must be signed in to change notification settings - Fork 0
[ENG-2202]: handle InboxMessageDeliveredFromOrigin event #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c64c788 to
a5a106e
Compare
|
With this PR do we want to go back to using the non-forked version of the nitro contracts? Currently we deploy our forked version of the contracts from your PR here. |
|
That's an excellent point @calebguy. In practice yes, we can just use the vanilla contracts. |
Think it's the other way around - the forked contracts use more gas, but allow for faster syncing of appchains as individual transactions no longer need to be fetched, just event logs. That said, removing the fork makes it easier to use arbitrum tooling to upgrade the contracts, so I'm in favor of that once this pr is merged. |
|
Yes @tsite, you're right - thanks for correcting this. Anyway, it probably doesn't justify keeping the fork. |
tsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a huge improvement! I left a couple comments, but this is great and removing the forked nitro contracts will make upgrades and maintenance a lot simpler
e8069e0 to
80acdb1
Compare
Ticket
sendL2MessageFromOrigineventsWhat does this PR do?
adds support for the InboxMessageDeliveredFromOrigin to the read loop (ingestor + translator in particular).
It works by making the ingestor keep the tx_hashes for each log in the partial blocks and then translator can fetch the necessary calldata once it sees a log of the InboxMessageDeliveredFromOrigin type