Skip to content

Conversation

@jorgemmsilva
Copy link
Collaborator

@jorgemmsilva jorgemmsilva commented Nov 5, 2025

Ticket

What does this PR do?

  • Summary:
    adds support for the InboxMessageDeliveredFromOrigin to the read loop (ingestor + translator in particular).
    It works by making the ingestor keep the tx_hashes for each log in the partial blocks and then translator can fetch the necessary calldata once it sees a log of the InboxMessageDeliveredFromOrigin type

@jorgemmsilva jorgemmsilva changed the title Inbox msg from origin [ENG-2202]: handle InboxMessageDeliveredFromOrigin event Nov 5, 2025
@jorgemmsilva jorgemmsilva force-pushed the inbox-msg-from-origin branch from c64c788 to a5a106e Compare November 6, 2025 13:33
@calebguy
Copy link
Collaborator

calebguy commented Nov 6, 2025

With this PR do we want to go back to using the non-forked version of the nitro contracts? Currently we deploy our forked version of the contracts from your PR here.

@jorgemmsilva
Copy link
Collaborator Author

That's an excellent point @calebguy. In practice yes, we can just use the vanilla contracts.
The gas savings are not so big that it justifies keeping a forked version of the contracts IMO, but that's something to discuss with the team 👍

@tsite
Copy link
Contributor

tsite commented Nov 6, 2025

That's an excellent point @calebguy. In practice yes, we can just use the vanilla contracts. The gas savings are not so big that it justifies keeping a forked version of the contracts IMO, but that's something to discuss with the team 👍

Think it's the other way around - the forked contracts use more gas, but allow for faster syncing of appchains as individual transactions no longer need to be fetched, just event logs. That said, removing the fork makes it easier to use arbitrum tooling to upgrade the contracts, so I'm in favor of that once this pr is merged.

@jorgemmsilva
Copy link
Collaborator Author

Yes @tsite, you're right - thanks for correcting this. Anyway, it probably doesn't justify keeping the fork.

Copy link
Contributor

@tsite tsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a huge improvement! I left a couple comments, but this is great and removing the forked nitro contracts will make upgrades and maintenance a lot simpler

@jorgemmsilva jorgemmsilva requested a review from tsite November 14, 2025 15:33
@jorgemmsilva jorgemmsilva merged commit 1fabb7c into main Nov 14, 2025
14 checks passed
@jorgemmsilva jorgemmsilva deleted the inbox-msg-from-origin branch November 14, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants