ST6RI-900 Actor and stakeholder parameters are not implicitly redefined #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a non-conformance in the implementation of implied redefinitions for actor and stakeholder parameters.
The KerML semantic constraint
checkFeatureParameterRedefinitionrequires that a feature that is a parameter redefine the parameter at the same position in any supertype of its owning type (with exceptions only for result parameters and parameters of positional invocations). However, in the implementation, actor and stakeholder parameters were not being given implicit redefinitions to meet this constraint.In fact, prevously, the
PartUsageAdapterspecifically overrode the methodisIgnoredParameterso that actor and stakeholder parameters were not given implicit redefinitions. Since this is not conformant with the specification, this override now has been removed.