Skip to content

Conversation

@pjljvandelaar
Copy link
Collaborator

F_Renames of Generic (Package | Subp) Renaming Decl[arations] no longer returns a Name but a Renaming_Clause.

This change caused the following errors

extraction-decl_types.adb:18:58: error: expected type "Name'Class" defined at libadalang-analysis.ads:285
extraction-decl_types.adb:18:58: error: found private type "Renaming_Clause" defined at libadalang-analysis.ads:2833
extraction-renamings.adb:34:63: error: expected private type "Name" defined at libadalang-analysis.ads:285
extraction-renamings.adb:34:63: error: found private type "Renaming_Clause" defined at libadalang-analysis.ads:2833
extraction-renamings.adb:38:60: error: expected private type "Name" defined at libadalang-analysis.ads:285
extraction-renamings.adb:38:60: error: found private type "Renaming_Clause" defined at libadalang-analysis.ads:2833

The Name of a Renaming Clause can be obtained using F_Renamed_Object.

This pull request fixes these errors.

Since libadalang 23, the Ada_Type_Decl is no longer an enumeration value of Ada_Node_Kind_Type, but an enumeration range thereof:

      subtype Ada_Type_Decl is Ada_Node_Kind_Type
            range Ada_Anonymous_Type_Decl .. Ada_Formal_Type_Decl;

This enumeration range includes the following 4 values:

	Ada_Anonymous_Type_Decl, Ada_Synth_Anonymous_Type_Decl, Ada_Concrete_Type_Decl, and Ada_Formal_Type_Decl
extraction-bodies_for_entries.adb:27:57: error: no selector "F_Name" for private type "Accept_Stmt" defined at libadalang-analysis.ads:300

	Accept_Stmt provides P_Corresponding_Entry, hence we don't need F_Name anymore to find the corresponding refenced declaration ourselves.
extraction-decl_types.adb:18:58: error: expected type "Name'Class" defined at libadalang-analysis.ads:285
extraction-decl_types.adb:18:58: error: found private type "Renaming_Clause" defined at libadalang-analysis.ads:2833
extraction-renamings.adb:34:63: error: expected private type "Name" defined at libadalang-analysis.ads:285
extraction-renamings.adb:34:63: error: found private type "Renaming_Clause" defined at libadalang-analysis.ads:2833
extraction-renamings.adb:38:60: error: expected private type "Name" defined at libadalang-analysis.ads:285
extraction-renamings.adb:38:60: error: found private type "Renaming_Clause" defined at libadalang-analysis.ads:2833

	`F_Renames` of Generic (Package | Subp) Renaming Decl[arations] no longer returns a `Name` but a `Renaming_Clause`.
	`Name` of a `Renaming Clause` can be obtained using `F_Renamed_Object`.
We seem unable to use v4.
See alire-project/setup-alire#87
Try v3 instead.
Default alire setting trigger an issue with too long paths on windows.
See alire-project/alire#1762

Use work around (as suggested).
@pjljvandelaar
Copy link
Collaborator Author

Still to do - fix "example" - needs rejuvenation-ada 2025 for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants