Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/thick-mangos-remain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@tanstack/query-core": patch
"@tanstack/react-query": patch
"@tanstack/solid-query": patch
---

feat(core): add queryKey to QueryObserverResult
1 change: 1 addition & 0 deletions packages/query-core/src/queryObserver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,7 @@ export class QueryObserver<
refetch: this.refetch,
promise: this.#currentThenable,
isEnabled: resolveEnabled(options.enabled, query) !== false,
queryKey: query.queryKey,
}

const nextResult = result as QueryObserverResult<TData, TError>
Expand Down
4 changes: 4 additions & 0 deletions packages/query-core/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,10 @@ export interface QueryObserverBaseResult<
TData = unknown,
TError = DefaultError,
> {
/**
* The query key used by the query.
*/
queryKey: QueryKey
/**
* The last successfully resolved data for the query.
*/
Expand Down
7 changes: 5 additions & 2 deletions packages/react-query/src/__tests__/useQuery.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ describe('useQuery', () => {
expect(states.length).toEqual(2)

expect(states[0]).toEqual({
queryKey: key,
data: undefined,
dataUpdatedAt: 0,
error: null,
Expand Down Expand Up @@ -129,6 +130,7 @@ describe('useQuery', () => {
})

expect(states[1]).toEqual({
queryKey: key,
data: 'test',
dataUpdatedAt: expect.any(Number),
error: null,
Expand Down Expand Up @@ -192,6 +194,7 @@ describe('useQuery', () => {
rendered.getByText('Status: error')

expect(states[0]).toEqual({
queryKey: key,
data: undefined,
dataUpdatedAt: 0,
error: null,
Expand Down Expand Up @@ -221,6 +224,7 @@ describe('useQuery', () => {
})

expect(states[1]).toEqual({
queryKey: key,
data: undefined,
dataUpdatedAt: 0,
error: null,
Expand Down Expand Up @@ -250,6 +254,7 @@ describe('useQuery', () => {
})

expect(states[2]).toEqual({
queryKey: key,
data: undefined,
dataUpdatedAt: 0,
error: new Error('rejected #2'),
Expand Down Expand Up @@ -6788,7 +6793,6 @@ describe('useQuery', () => {
let fetchCount = 0
const queryFn = vi.fn().mockImplementation(() => {
fetchCount++
console.log(`Fetching... (attempt ${fetchCount})`)
return Promise.reject(new Error('Simulated 500 error'))
})

Expand Down Expand Up @@ -6906,7 +6910,6 @@ describe('useQuery', () => {
let fetchCount = 0
const queryFn = vi.fn().mockImplementation(() => {
fetchCount++
console.log(`Fetching... (attempt ${fetchCount})`)
return Promise.reject(new Error('Simulated 500 error'))
})

Expand Down
5 changes: 5 additions & 0 deletions packages/solid-query/src/__tests__/useQuery.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ describe('useQuery', () => {
expect(states.length).toEqual(2)

expect(states[0]).toEqual({
queryKey: key,
data: undefined,
dataUpdatedAt: 0,
error: null,
Expand Down Expand Up @@ -318,6 +319,7 @@ describe('useQuery', () => {
})

expect(states[1]).toEqual({
queryKey: key,
data: 'test',
dataUpdatedAt: expect.any(Number),
error: null,
Expand Down Expand Up @@ -384,6 +386,7 @@ describe('useQuery', () => {
expect(rendered.getByText('Status: error')).toBeInTheDocument()

expect(states[0]).toEqual({
queryKey: key,
data: undefined,
dataUpdatedAt: 0,
error: null,
Expand Down Expand Up @@ -413,6 +416,7 @@ describe('useQuery', () => {
})

expect(states[1]).toEqual({
queryKey: key,
data: undefined,
dataUpdatedAt: 0,
error: null,
Expand Down Expand Up @@ -442,6 +446,7 @@ describe('useQuery', () => {
})

expect(states[2]).toEqual({
queryKey: key,
data: undefined,
dataUpdatedAt: 0,
error: new Error('rejected'),
Expand Down
Loading