Skip to content

fix(eslint-plugin-query): add ESLint v10 to peerDependencies#10152

Open
mixelburg wants to merge 1 commit intoTanStack:mainfrom
mixelburg:fix/eslint-v10-peer-dep
Open

fix(eslint-plugin-query): add ESLint v10 to peerDependencies#10152
mixelburg wants to merge 1 commit intoTanStack:mainfrom
mixelburg:fix/eslint-v10-peer-dep

Conversation

@mixelburg
Copy link

@mixelburg mixelburg commented Feb 18, 2026

Adds ESLint v10 to the supported peerDependencies range for @tanstack/eslint-plugin-query.

ESLint v10 was released recently and the plugin is compatible — it doesn't use any of the removed/deprecated APIs (FlatESLint, LegacyESLint, eslintrc config format). All existing tests pass without changes.

Resolves #10141

Summary by CodeRabbit

  • Chores
    • Extended ESLint peer dependency support to include version 10.0.0, enabling compatibility with the latest ESLint releases.

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2026

⚠️ No Changeset found

Latest commit: 0f68746

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

📝 Walkthrough

Walkthrough

Updated the eslint-plugin-query package to declare compatibility with ESLint v10 by extending the peer dependency version range to include the newly released major version alongside existing v8 and v9 support.

Changes

Cohort / File(s) Summary
ESLint v10 Support
packages/eslint-plugin-query/package.json
Extended peerDependencies.eslint range from `^8.57.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • lachlancollins
  • TkDodo

Poem

🐰 ESLint v10 hops into view,
Our plugin declares: "I support you too!"
Version range expands with a joyful bound,
From eight through ten, compatibility found! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding ESLint v10 support to the eslint-plugin-query peerDependencies.
Description check ✅ Passed The description provides clear context about the change and its motivation, but the PR template checklist sections are incomplete or missing.
Linked Issues check ✅ Passed The PR directly addresses issue #10141 by adding ESLint v10 to peerDependencies, meeting the requirement for explicit compatibility declaration.
Out of Scope Changes check ✅ Passed All changes are scoped to updating the ESLint peerDependency range as required; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/eslint-plugin-query/package.json (1)

62-63: ⚠️ Potential issue | 🟠 Major

@typescript-eslint/utils ^8.48.0 does not declare ESLint v10 compatibility in its peerDependencies.

typescript-eslint v8.56.0 (released Feb 16, 2026) added code-level support for ESLint v10, but its peerDependencies.eslint still declares only ^8.57.0 || ^9.0.0. This means npm and pnpm will emit an unmet peerDependency warning when pairing this package with ESLint v10, even though the code technically supports it.

A follow-up release from typescript-eslint (v8.57.0 or later) that updates the eslint peerDependency range to include ^10.0.0 is needed to fully resolve this. Until then, the dependency will produce warnings in ESLint v10 environments.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/eslint-plugin-query/package.json` around lines 62 - 63, Update the
`@typescript-eslint/utils` dependency in package.json (the
"@typescript-eslint/utils" entry) to a version >= 8.57.0 (for example "^8.57.0")
so the typescript-eslint package includes ESLint v10 in its peerDependencies and
avoids peer dependency warnings in ESLint v10 environments; modify the version
string for "@typescript-eslint/utils" accordingly and run install to verify no
peerDependency warnings remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@packages/eslint-plugin-query/package.json`:
- Around line 62-63: Update the `@typescript-eslint/utils` dependency in
package.json (the "@typescript-eslint/utils" entry) to a version >= 8.57.0 (for
example "^8.57.0") so the typescript-eslint package includes ESLint v10 in its
peerDependencies and avoids peer dependency warnings in ESLint v10 environments;
modify the version string for "@typescript-eslint/utils" accordingly and run
install to verify no peerDependency warnings remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eslint-plugin-query: support eslint v10

1 participant

Comments