-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Vue router #5997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Vue router #5997
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit b3eac9e
☁️ Nx Cloud last updated this comment at |
| @@ -0,0 +1,5 @@ | |||
| <img src="https://static.scarf.sh/a.png?x-pxid=d988eb79-b0fc-4a2b-8514-6a1ab932d188" /> | |||
|
|
|||
| # TanStack Solid Router Devtools | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # TanStack Solid Router Devtools | |
| # TanStack Vue Router Devtools |
| "declaration": true, | ||
| "sourceMap": true, | ||
| "paths": { | ||
| "@tanstack/router-devtools-core": ["../../router-devtools-core/src"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? Or just for initial dev?
| /** | ||
| * @deprecated use createRouter's `scrollRestoration` option instead | ||
| */ | ||
| export function ScrollRestoration(_props: ScrollRestorationOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to provide this component?
Since a Vue single-file component (SFC) only can export one component, and most tanstack router routes export multiple (main component, error compoentn, not found component etc.) the iteration here uses either JSX or multiple vue files like this:
File-Based Routing Conventions
optional vue-specific route files
.component.vue.errorComponent.vue.notFoundComponent.vue.pendingComponent.vueexisting
.ts.lazy.ts_layoutprefix_suffix (e.g.,posts_.$postId)(groupName)directory$param