Skip to content

refactor(router-core): improve server store performance by removing getter/setter #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sheraff merged 1 commit into from
Jan 25, 2026
+5 −10
Merged

refactor(router-core): improve server store performance by removing getter/setter #6502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions packages/router-core/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,19 +907,14 @@ type RouterStateStore<TState> = {
function createServerStore<TState>(
initialState: TState,
): RouterStateStore<TState> {
let state = initialState

return {
get state() {
return state
},
set state(next) {
state = next
},
const store = {
state: initialState,
setState: (updater: (prev: TState) => TState) => {
state = updater(state)
store.state = updater(store.state)
},
} as RouterStateStore<TState>

return store
}

export class RouterCore<
Expand Down
Loading