Skip to content

Conversation

@inemtsev
Copy link
Contributor

@inemtsev inemtsev commented Dec 5, 2025

  • Migrated Maven to Gradle build
  • Fixed Exposed and PgClient
  • Upgraded Ktor to latest
  • Some optimizations

@volyrique
Copy link
Contributor

Note that the ktor-exposed-dao and ktor-exposed-dsl implementations have been failing consistently since run 809d8655-c602-42a1-9d8c-dc4692738790, i.e. almost 4 months. I actually have a patch to mark them as broken (together with several others such as ktor-pgclient, which has started failing after the upgrade to PostgreSQL 18), but you could take care of it in this PR or fix them, of course.

@inemtsev
Copy link
Contributor Author

inemtsev commented Dec 5, 2025

Note that the ktor-exposed-dao and ktor-exposed-dsl implementations have been failing consistently since run 809d8655-c602-42a1-9d8c-dc4692738790, i.e. almost 4 months. I actually have a patch to mark them as broken (together with several others such as ktor-pgclient, which has started failing after the upgrade to PostgreSQL 18), but you could take care of it in this PR or fix them, of course.

Ok, I will take a look at them also

@inemtsev
Copy link
Contributor Author

inemtsev commented Dec 5, 2025

Ready to go from my end @volyrique

@volyrique
Copy link
Contributor

volyrique commented Dec 5, 2025

I can't do a formal review of your PR, nor am I able to review Kotlin code, but unlike before, all tests pass now, so it looks good to me.

@inemtsev
Copy link
Contributor Author

inemtsev commented Dec 6, 2025

@tmohme Can you please give your blessings?

@inemtsev
Copy link
Contributor Author

inemtsev commented Dec 6, 2025

@bjhham Can you please give blessings?

@inemtsev
Copy link
Contributor Author

inemtsev commented Dec 6, 2025

@msmith-techempower Can you please take a look?

Copy link
Contributor

@bjhham bjhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Looks good!

Copy link
Contributor

@tmohme tmohme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same from me: Thanks for the update! Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants