-
Notifications
You must be signed in to change notification settings - Fork 2k
update ktor to user Gradle #10365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update ktor to user Gradle #10365
Conversation
|
Note that the |
Ok, I will take a look at them also |
|
Ready to go from my end @volyrique |
|
I can't do a formal review of your PR, nor am I able to review Kotlin code, but unlike before, all tests pass now, so it looks good to me. |
|
@tmohme Can you please give your blessings? |
|
@bjhham Can you please give blessings? |
|
@msmith-techempower Can you please take a look? |
bjhham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Looks good!
tmohme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same from me: Thanks for the update! Looks good!
Uh oh!
There was an error while loading. Please reload this page.