Skip to content

remove precomputed content length header from vertx impls#10664

Merged
msmith-techempower merged 2 commits intoTechEmpower:masterfrom
awmcc90:content-length-update
Feb 17, 2026
Merged

remove precomputed content length header from vertx impls#10664
msmith-techempower merged 2 commits intoTechEmpower:masterfrom
awmcc90:content-length-update

Conversation

@awmcc90
Copy link
Contributor

@awmcc90 awmcc90 commented Feb 3, 2026

./tfb \
  --mode benchmark \
  --test vertx-web-kotlin-dsljson vertx \
  --type json

@awmcc90
Copy link
Contributor Author

awmcc90 commented Feb 3, 2026

@vietj for visibility

@vietj
Copy link
Contributor

vietj commented Feb 3, 2026

what is the motivation for this ?

@awmcc90
Copy link
Contributor Author

awmcc90 commented Feb 3, 2026

^ @p8 and @joanhey

@joanhey
Copy link
Contributor

joanhey commented Feb 3, 2026

JSON Serialization
The JSON Serialization test exercises the framework fundamentals including keep-alive support, request routing, request header parsing, object instantiation, JSON serialization, response header generation, and request count throughput.

We need to generate the headers, not hard coded or with constants.

#10611 (comment)

@p8
Copy link
Contributor

p8 commented Feb 3, 2026

@joanhey
Copy link
Contributor

joanhey commented Feb 7, 2026

Please add the maintainers in the benchmark_config.json.

So with any change or marked as broken, it'll be notified to them.

Example:

{
"framework": "quarkus",
"maintainers": ["franz1981", "Sanne", "geoand"],
"tests": [
{
"default": {

@joanhey
Copy link
Contributor

joanhey commented Feb 11, 2026

Please add the maintainers, or the next time that is marked as broken, nobody will be notified.

@awmcc90
Copy link
Contributor Author

awmcc90 commented Feb 11, 2026

In the future please scope all work upfront to prevent a second pass. Thanks.

@joanhey
Copy link
Contributor

joanhey commented Feb 12, 2026

Please, help the other people that work for you.
Thank you !!

@joanhey
Copy link
Contributor

joanhey commented Feb 12, 2026

I'll explain how you was notified.
The easy part, it's mark the frameworks as broken or stripped.

I spend my time to notify the devs, for that I need to check in Github the framework and later the devs.

It's OK, but I'll do it one time, not more.

Thank you !!!

@joanhey
Copy link
Contributor

joanhey commented Feb 12, 2026

If it's to much work to add the maintainers, I can understate it.
But the next time nobody will be notified.

Thank you.

@msmith-techempower msmith-techempower merged commit 124ddb3 into TechEmpower:master Feb 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments