Skip to content

Repair Quarkus Vert.x benchmark#10736

Open
tsegismont wants to merge 1 commit intoTechEmpower:masterfrom
tsegismont:repair-quarkus-vertx
Open

Repair Quarkus Vert.x benchmark#10736
tsegismont wants to merge 1 commit intoTechEmpower:masterfrom
tsegismont:repair-quarkus-vertx

Conversation

@tsegismont
Copy link
Contributor

Follows-up on #10715

The Ongres SCRAM dependency is required for authentication with the database.

@github-actions
Copy link
Contributor

The following frameworks were updated, pinging maintainers:
quarkus: @franz1981, @Sanne, @geoand

@joanhey
Copy link
Contributor

joanhey commented Feb 11, 2026

Not only that, they need to calculate the length in each request !!!
#10715 (comment)

EDIT: or will be marked as stripped !!!

@joanhey
Copy link
Contributor

joanhey commented Feb 12, 2026

Another big problem is the use of constant for the length header that is not permitted.

private static final CharSequence HELLO_WORLD_LENGTH = HttpHeaders.createOptimized("" + HELLO_WORLD.length());

Ongres SCRAM was missing (required for authentication).

Signed-off-by: Thomas Segismont <tsegismo@ibm.com>
@tsegismont
Copy link
Contributor Author

@joanhey thanks for taking a look as well

Regarding your comments about the length header, I'm not a maintainer of this benchmark, consequently not in a position to discuss whether this should be changed.

The scope of this PR is repairing a broken benchmark, so not related to your issue anyway.

@joanhey
Copy link
Contributor

joanhey commented Feb 12, 2026

Without the header change, this PR will not be merged.
Or It'll be marked as Stripped.

@tsegismont
Copy link
Contributor Author

tsegismont commented Feb 17, 2026

Except for plaintext in quarkus-reactive-routes-pgclient and quarkus-vertx, no Quarkus benchmark computes the content length beforehand.

My understanding is that this is compliant with the rule as explained in #10611 (comment)

@joanhey @msmith-techempower if I didn't get the statement wrong, can we get this PR merged after one of the maintainers has approved the PR?

@msmith-techempower
Copy link
Member

@tsegismont I have to agree with @joanhey - we have been really pushing to be more equitable about the stripped implementations. Without the header changes or marking the implementation as 'Stripped', we won't merge. I recommend simply ensuring that the headers are computed on every request.

@tsegismont
Copy link
Contributor Author

Thanks for your answer @msmith-techempower

tl;dr - plaintext is the "fun" one where frameworks can do whatever they want to try and go brrrrr, but the rest need to follow the rules or the framework will be marked "Stripped".

So, this is no longer true?

@joanhey
Copy link
Contributor

joanhey commented Feb 18, 2026

If you want to play in the bench, you need to be a fair player !!
Thank you.

If you find another fw than make the same, please mark it as Stripped.

@tsegismont
Copy link
Contributor Author

If you want to play in the bench, you need to be a fair player !! Thank you.

If this is a general statement, I fully agree.

If you find another fw than make the same, please mark it as Stripped.

Sorry I'm not comfortable with sending PRs to other participants marking their implementation as stripped. I don't believe this would cultivate a positive competitive spirit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments