Week 7 project-github-tracker #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistscale
reviewed
Mar 2, 2022
mistscale
left a comment
mistscale
left a comment
There was a problem hiding this comment.
Good job with the project! Your script is well written and minimal. I really liked that you added a colourful hero image, makes the site very visually pleasing combined with the grayscale filter on your profile image. Beautiful tracker Josse! :D
Comment on lines
+15
to
+16
| backgroundColor: ['rgb(255, 99, 132)','rgb(255, 69, 0)'], | ||
| borderColor: ['rgb(255, 99, 132)','rgb(255, 69, 0)'], |
There was a problem hiding this comment.
Ah smart solution for "removing" the border on the chart!
Comment on lines
+92
to
+95
| //If any review made - positioning data by dynamic ID repoName | ||
| if (`${data[0].user.login} == ''`) { | ||
| document.getElementById(repoName).innerHTML += ` | ||
| <p>Review made by: ${data[0].user.login}</p>` |
There was a problem hiding this comment.
Impressive to add the username of the code reviewer
| } | ||
|
|
||
| .project-container :hover { | ||
| background: linear-gradient(90deg, #D1D1D1, #e6e6e6 50%, #e6e6e6 50%, #e6e6e6 50%, #D1D1D1); |
There was a problem hiding this comment.
Didn't notice the hover gradient at first but so nice with a subtle and minimal gradient. Have to try this out on a future project!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.