Week 7 - GitHub Tracker Jenny F #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const profileImage = document.getElementById('profileImage') | ||
| const projectBox = document.getElementById('projects') | ||
| const repoName = document.getElementById('reponame') | ||
|
|
There was a problem hiding this comment.
Code looks neat and easy to understand
Sherin-Susan-Thomas
approved these changes
Mar 3, 2022
Sherin-Susan-Thomas
left a comment
Sherin-Susan-Thomas
left a comment
There was a problem hiding this comment.
Good Job with the project. The code was neatly written and very easy to understand. The blue requirements were fulfilled except the fetching all the repos part which should be corrected. The styling was good and page was responsive.
| const options = { | ||
| method: 'GET', | ||
| headers: { | ||
| Authorization: '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' // my TOKEN |
There was a problem hiding this comment.
Its better to add token in separate file and add it to gitignore to prevent GitHub revoking the key
| h3{ | ||
| font-size: 35pt; | ||
| text-align: center; | ||
| color: rgb(216, 83, 128); |
| </div> | ||
| `; | ||
| getPullRequests(technigoRepos); | ||
| drawChart(technigoRepos.length); //* if this one is commented out, more projects will appear. Do not know why. |
There was a problem hiding this comment.
if you can change the drawChart(technigoRepos.length) to line 61 the error will get corrected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.