-
Notifications
You must be signed in to change notification settings - Fork 131
final #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
final #103
Conversation
TereseClaesson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A clear, well structured and consistent kod, with good comments. Easy to follow your code and it looks great. Well done!
| .then((data) => { | ||
| const technigoRepo = data.filter( | ||
| // FILTERS MY FORKED REPOS ONLY TO DESPLAY THE ONES NAMNED "project-" | ||
| (repo) => repo.name.includes('project-') && repo.fork |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have done a great job and I see that you have used includes(),I will learn from that ;) It's also possible to use startsWith() when searching for 'projects-', that is what i did in my project.
|
|
||
| //DOM SELECTOR | ||
| const projects = document.getElementById('projects-container') | ||
| //FETCH API AND FILTERS REPO. INJECTS REPO URL, NAME, DEF BRANCH, PUSHED DATE AND COMMIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clear and concise comment!
| const GITHUB_USER_API = `https://api.github.com/users/${username}` | ||
| const GITHUB_REPOS_API = `https://api.github.com/users/${username}/repos` | ||
|
|
||
| //FETCH API TO PROFILE. INJECTS PIC,USERNAME,BIO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clear and concise comment!
No description provided.