project-github-tracker-JaEngd #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawisou
reviewed
Feb 28, 2022
rawisou
left a comment
rawisou
left a comment
There was a problem hiding this comment.
Your website is responsive and works as intended.
Good work putting time into the authentication part.
Just one small comment for the pull requests in the requirements. that I wanted to bring up. :)
| showCommits(myPullRequest.commits_url, repo.name) | ||
| } else { | ||
| document.getElementById(`commit_${repo.name}`) | ||
| .innerHTML = 'Commits: No Pull request available.'; |
There was a problem hiding this comment.
Maybe the 'Commits: No Pull request available.' line 76 should be Pull request?
I'm not sure where the pull request part (link or num of pull request) is displayed. All pull requests are mentioned in the 'what to include' part.
--- Sorry, I misunderstood. The pull requests were not required in the Blue Level---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.