Skip to content

Conversation

@jjwwkkmm
Copy link

Link to my deployed project:
https://flamboyant-jackson-27aaa3.netlify.app/

My reflections on how this week's project turned out:
The work with API went well, however it was harder to keep the code clean/concise, thus this is a working point that can be improved. Even though I am happy with it displaying all information required I would like to refactor the code more, since I know it's possible.

Things I'd like to have clarified or explained in more detail:
Nothing I would like to have explained, rather things I would like to practice more which I know are of importance, such as promises and async/await (which is currently not used in this particular project) and passing values through functions without it losing its context (closures, scopes and binding I believe).

Copy link

@EmmaSprings EmmaSprings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, very well done! Your GitHub tracker works fine when viewing it, no bugs here.

I like how you added the commits and pull requests to its own section as a status bar! Very clever.

To me, the code is easy to read and understand. I read you would like to refactor the code a bit more, And even though it works perfectly fine as is, of course that could be nice thing to practice on, and I’m sure you will get the chance in other projects, so to just think about it now is really cool!

Nice and clean styling makes it easy to follow your process too.

You’ve definitely reached the blue level requirements and you should be really happy with your project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants