github-tracker-Vanessa #110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyahya-khan
approved these changes
Mar 2, 2022
eyahya-khan
left a comment
eyahya-khan
left a comment
There was a problem hiding this comment.
Thanks for overall good coding in all section.
| //DOM-selector for the canvas 👇 | ||
| const ctx = document.getElementById('chart').getContext('2d') | ||
| const ctx = document.getElementById('chart').getContext('2d'); | ||
|
|
| }; | ||
| const myChart = new Chart(document.getElementById('chart'), config); | ||
| }; | ||
|
|
|
|
||
| <script src="./secret.js"></script> | ||
| <script src="./script.js"></script> | ||
| <script src="./chart.js"></script> |
There was a problem hiding this comment.
link all js file but script.js will be last in order for better functioning.
| Authorization: `token ${API_TOKEN}`, | ||
| }, | ||
| }; | ||
|
|
| // console.log('nu då?'); | ||
| }); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Overall very good work and effort to display all outcome.
| display: flex; | ||
| flex-wrap: wrap; | ||
| } | ||
| } |
There was a problem hiding this comment.
CSS is very good also. thanks for better css code structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.