Project Github Tracker #99
Conversation
id4h4lling
left a comment
id4h4lling
left a comment
There was a problem hiding this comment.
Good job on this project, and a loud high five on completing the token! ✋
Nicely structured code, good looking color scheme and all the why true informative comments that explain each function. You gonna go far! ⭐️⭐️⭐️⭐️⭐️ or maybe 👩💻👩💻👩💻👩💻👩💻 out of 5.
|
|
||
| const options = { | ||
| method: 'GET', | ||
| headers: { | ||
| Authorization: `token ${API_TOKEN}` | ||
| } | ||
| } |
| const getIntro = () => { | ||
| fetch(API_URL_ID, options).then(res => res.json()).then(data => { | ||
| userInfo.innerHTML = `<h2>${data.name}</h2><a href=${data.html_url}> <h2> <img class="logo"src="./GitHubMark.png"> ${data.login} </h2></a>` | ||
| avatar.src = data.avatar_url |
There was a problem hiding this comment.
U could write <img class="profile-img" src="${user.avatar_url}"> inside of the backticks, instead of declaring a variable above. Since you should be able to fetch that from the API: API_URL_ID. Or at least it did for me.
| console.log(forkedRepos) | ||
| forkedRepos.forEach((repo) => projects.innerHTML += ` | ||
| <div class="repo"> | ||
| <img class="logo"src="./GitHubMark.png"> |
| getRepos() | ||
| }) | ||
| } | ||
| //second function, fetches my repos and filters the ones that are forked and stars with project. Displays info. |
There was a problem hiding this comment.
Good comments all the way through, makes it easy to understand. ⭐️
| @import url('https://fonts.googleapis.com/css2?family=Oswald:wght@300&family=Roboto:wght@300&display=swap'); | ||
| @import url('https://fonts.googleapis.com/css2?family=Bebas+Neue&display=swap'); |
There was a problem hiding this comment.
A, you put fonts in the css instead of the html! Is that better in some way? Curious!
2 participants
No description provided.