Skip to content

TryParseReverseDomain should fail on invalid IPv4 addresses such as one octet less or more. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zbalkan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

TryParseReverseDomain should fail on invalid IPv4 addresses such as one octet less or more. #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1b349
TryParseReverseDomain should fail on invalid IPv4 addresses such as o…
zbalkan Jan 29, 2026
a59e4a6
Added copyright
zbalkan Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions TechnitiumLibrary.Net/IPAddressExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/*
Technitium Library
Copyright (C) 2025 Shreyas Zare (shreyas@technitium.com)
Copyright (C) 2026 Zafer Balkan (zafer@zaferbalkan.com)

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
Expand Down Expand Up @@ -444,6 +445,14 @@ public static bool TryParseReverseDomain(string ptrDomain, out IPAddress address
//192.168.10.1

string[] parts = ptrDomain.Split('.');

// Expecting 6 parts: 4 octets + in-addr + arpa
if (parts.Length != 6)
{
address = null;
return false;
}

Span<byte> buffer = stackalloc byte[4];

for (int i = 0, j = parts.Length - 3; (i < 4) && (j > -1); i++, j--)
Expand Down