Skip to content

tests: add actionable error test for mismatched closing tag in markup #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lesliehc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: add actionable error test for mismatched closing tag in markup #3899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_markup_error_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import pytest
from rich.text import Text
from rich.errors import MarkupError

def test_invalid_markup_message_is_actionable_mismatched_close():
bad = "[bold]hello[/italic]" # mismatched closing tag should raise
with pytest.raises(MarkupError) as exc:
Text.from_markup(bad)

msg = str(exc.value).lower()
# keep the assertions flexible so they work with current Rich messaging
assert any(word in msg for word in ("invalid", "mismatch", "closing", "end tag"))