You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't output extraneous blank line when progress display is disabled
Type of changes
Bug fix
New feature
Documentation / docstrings
Tests
Other
AI?
AI was used to generate this PR
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist
I've run the latest black with default args on new code.
I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate (see note about typos above).
I've added tests for new code.
I accept that @willmcgugan may be pedantic in the code review.
Description
When creating a Progress with disabled=True, it still outputs a blank line on non interactive consoles. This PR adds an if not self.disable to the stop function, symmetrically to the start function.
Important: Link to an issue or discussion regarding these changes.
Don't output extraneous blank line when progress display is disabled
Type of changes
Bug fix
New feature
Documentation / docstrings
Tests
Other
AI?
AI was used to generate this PR
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist
I've run the latest black with default args on new code.
I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate (see note about typos above).
I've added tests for new code.
I accept that @willmcgugan may be pedantic in the code review.
Description
When creating a Progress with disabled=True, it still outputs a blank line on non interactive consoles. This PR adds an if not self.disable to the stop function, symmetrically to the start function.
Important: Link to an issue or discussion regarding these changes.
Don't output extraneous blank line when progress display is disabled
Type of changes
Bug fix
New feature
Documentation / docstrings
Tests
Other
AI?
AI was used to generate this PR
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist
I've run the latest black with default args on new code.
I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate (see note about typos above).
I've added tests for new code.
I accept that @willmcgugan may be pedantic in the code review.
Description
When creating a Progress with disabled=True, it still outputs a blank line on non interactive consoles. This PR adds an if not self.disable to the stop function, symmetrically to the start function.
Important: Link to an issue or discussion regarding these changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't output extraneous blank line when progress display is disabled
Type of changes
AI?
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist
Description
When creating a
Progresswithdisabled=True, it still outputs a blank line on non interactive consoles. This PR adds anif not self.disableto thestopfunction, symmetrically to thestartfunction.Important: Link to an issue or discussion regarding these changes.
#110