rsz: design area include tap#9452
rsz: design area include tap#9452gudeh wants to merge 12 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to include end cap and tap cells in the design area calculation, which is used for reporting utilization. The change in Resizer.cc correctly achieves this by removing the conditions that excluded these cell types.
My review includes a suggestion to make the filler cell exclusion logic more robust. The current implementation relies on isFiller(), which appears to be incomplete. A more comprehensive check would improve the accuracy of the design area report.
| if (!master->isFiller() | ||
| && master->getType() != odb::dbMasterType::CORE_WELLTAP | ||
| && !master->isEndCap()) { | ||
| if (!master->isFiller()) { |
There was a problem hiding this comment.
While this change correctly includes welltap and endcap cells in the design area calculation, it now relies solely on isFiller(), which seems to have an incomplete definition as it only identifies CORE_SPACER as a filler. Other filler-like cells such as PAD_SPACER and COVER cells will still be counted in the design area, which may not be desirable for an accurate utilization report.
For a more robust implementation that correctly excludes all filler types, consider this more comprehensive check.
if (!master->isFiller() && !master->isCover() && master->getType() != odb::dbMasterType::PAD_SPACER) {
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
The change is trivial but will need a secure CI check |
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
2 participants
We are currently not accounting for end caps and tap cells when reporting the area and utilization for the user.
The modified rsz function is used for the command used multiple times in ORFS:
report_design_area.The
report_design_areais called byreport_metrics, and has the following format:I triggered a secure-CI and this seems to be no-op.