temporarily disable 6 bzl tests#9527
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Feb 23, 2026
Merged
Conversation
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request temporarily disables several Bazel tests by commenting out their definitions in the BUILD files. This action aligns with the pull request's title and description, indicating a temporary measure, likely for debugging or addressing current failures. While commenting out code is a quick way to disable functionality, it's generally preferable to use Bazel's built-in mechanisms for disabling tests (e.g., tags = ["manual"] or exclusive = True for temporary local disablement, or dedicated configuration flags for broader control) to maintain cleaner build files. However, for a temporary disablement, this approach is functional.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.