Fix some uses of using namespace#9528
Fix some uses of using namespace#9528hzeller wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
using namespace#9528Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the broad using namespace sta; with specific using declarations in RepairDesign.cc and RepairHold.cc. This is a good practice to avoid namespace pollution and potential symbol conflicts. However, some symbols that were previously available via the sta namespace (either directly or through nested using declarations in OpenSTA headers) are now missing, which will lead to compilation errors. Specifically, sta::Slacks and std::sort need to be explicitly imported or qualified where they are used unqualified.
|
clang-tidy review says "All clean, LGTM! 👍" |
hzeller
force-pushed
the
feature-20260223-no-use-ns
branch
2 times, most recently
from
bb05061 to
cd6c3f9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260223-no-use-ns
branch
from
cd6c3f9 to
692a6a7
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
What's the motivation? I understood the motivation to get rid of |
|
I see #9525, let's discuss there |
2 participants
No description provided.