gui: Set default scene to prevent null deref#9531
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Feb 24, 2026
Merged
gui: Set default scene to prevent null deref#9531maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Martin Povišer <povik@cutebit.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The review correctly identifies a critical null pointer dereference in the setSTA method, where sta->cmdScene() is called without a null check for sta. The suggested fix, which mirrors the null check in the constructor, is appropriate to prevent a crash.
Comment on lines
+329
to
+333
| void setSTA(sta::dbSta* sta) | ||
| { | ||
| sta_ = sta; | ||
| scene_ = sta->cmdScene(); | ||
| } |
Contributor
There was a problem hiding this comment.
The sta pointer can be null, which will cause a null pointer dereference when sta->cmdScene() is called. A null check should be added, similar to the one in the constructor, to prevent a crash.
Suggested change
| void setSTA(sta::dbSta* sta) | |
| { | |
| sta_ = sta; | |
| scene_ = sta->cmdScene(); | |
| } | |
| void setSTA(sta::dbSta* sta) | |
| { | |
| sta_ = sta; | |
| scene_ = sta ? sta->cmdScene() : nullptr; | |
| } |
Contributor
There was a problem hiding this comment.
I'm not sure there's a code path which would do setSTA(nullptr);
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Feb 24, 2026
maliberty
merged commit 446934a
into
The-OpenROAD-Project:master
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be fixing #9526