bazel/tcl: migrate from rules_hdl tcl to bazel BCR tcl version#290
Open
fredowski wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
bazel/tcl: migrate from rules_hdl tcl to bazel BCR tcl version#290fredowski wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
fredowski wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
fredowski
pushed a commit
to fredowski/OpenROAD
that referenced
this pull request
Feb 18, 2026
The sta submodule needs to be modified to use the bcr tcl version. I made a PR for the change in the OpenSTA repository here: The-OpenROAD-Project/OpenSTA#290 Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
Contributor
|
@QuantamHD @maliberty Can you have a look and merge ? |
fredowski
pushed a commit
to fredowski/OpenROAD
that referenced
this pull request
Feb 20, 2026
The sta submodule needs to be modified to use the bcr tcl version. I made a PR for the change in the OpenSTA repository here: The-OpenROAD-Project/OpenSTA#290 Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
The tcl version in the bazel central registry supports MacOS and it can be used via MODULES.bazel instead of WORKSPACE. Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
fredowski
pushed a commit
to fredowski/OpenROAD
that referenced
this pull request
Feb 22, 2026
The sta submodule needs to be modified to use the bcr tcl version. I made a PR for the change in the OpenSTA repository here: The-OpenROAD-Project/OpenSTA#290 Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
fredowski
pushed a commit
to fredowski/OpenROAD
that referenced
this pull request
Feb 22, 2026
The sta submodule needs to be modified to use the bcr tcl version. I made a PR for the change in the OpenSTA repository here: The-OpenROAD-Project/OpenSTA#290 Signed-off-by: Friedrich Beckmann <friedrich.beckmann@tha.de>
Contributor
|
@QuantamHD @maliberty can you approve and merge ? |
Contributor
|
mmh, looks like |
Contributor
|
Ah, looks like this accidentally worked as the other PR updated this fork in a separate commit. So that commit is disconnected from anything. So this PR still needs to be merged, to then have a clean submodule update in OpenROAD. |
Author
|
Yes, this is github magic. The commit is in my forked OpenSTA. For me it looks like this:
The bazel-tcl branch is the one from the tcl pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tcl version in the bazel central registry supports MacOS and it can be used via MODULES.bazel instead of WORKSPACE.