Skip to content

Conversation

@ShadowMitia
Copy link
Contributor

This adds bubble sort to the set of algorithmsf or OCaml.

The "sorting" folder was added as the repos in other languages seem to be doing the same thing.

I've left the tests I was using in the file, I'm not sure if it's a good practice. Let me know if I need to remove it or change it.

@spamegg1
Copy link
Contributor

spamegg1 commented Oct 4, 2020

I also added a folder named Sorts so depending on who gets merged first, one of us might have to change the folder name. I'm not sure about folder naming conventions in OCaml.

I also left the tests inside the file, as I also wasn't sure. Since the repo doesn't have anything in it ATM, it's hard to tell. On some repos like TheAlgorithms/Python they often leave tests inside the file. On others like TheAlgorithms/Haskell the tests are in a separate folder and file. It depends on the language and how/if automated testing is set up.

We'll just have to wait and see. Hopefully the owner can guide us.

@ShadowMitia
Copy link
Contributor Author

I don't mind either. Having a couple of tests just for documentation seems like a good idea, even if it's not proper TDD.

@ShadowMitia
Copy link
Contributor Author

I renamed the folder to match the already existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants