Skip to content

Comments

Added Johnson's algorithm for all-pairs shortest paths#13340

Open
sangampaudel530 wants to merge 4 commits intoTheAlgorithms:masterfrom
sangampaudel530:graphs/add-johnsons-algorithm
Open

Added Johnson's algorithm for all-pairs shortest paths#13340
sangampaudel530 wants to merge 4 commits intoTheAlgorithms:masterfrom
sangampaudel530:graphs/add-johnsons-algorithm

Conversation

@sangampaudel530
Copy link

@sangampaudel530 sangampaudel530 commented Oct 8, 2025

Describe your change:

This PR adds Johnson's algorithm for computing all-pairs shortest paths in a weighted graph. The implementation handles graphs with negative edge weights (but no negative cycles) by combining Bellman-Ford and Dijkstra algorithms. A corresponding test file test_johnson.py is also included to validate correctness.

  • Add an algorithm
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation: Johnson's algorithm
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the require descriptive names This PR needs descriptive function and/or variable names label Oct 8, 2025
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 8, 2025
@algorithms-keeper algorithms-keeper bot removed the require descriptive names This PR needs descriptive function and/or variable names label Oct 8, 2025
@sangampaudel530 sangampaudel530 changed the title Fix typos in Johnson's algorithm (nd -> and) to pass codespell Add Johnson's algorithm for all-pairs shortest paths with tests Oct 8, 2025
@sangampaudel530 sangampaudel530 changed the title Add Johnson's algorithm for all-pairs shortest paths with tests Added Johnson's algorithm for all-pairs shortest paths Oct 10, 2025
@sangampaudel530
Copy link
Author

sangampaudel530 commented Oct 14, 2025

Hi @cclauss @MaximSmolskiy Could you review this pr and give some feedback. Could you please merge this after reviewing it ?

@sangampaudel530
Copy link
Author

Hi @cclauss , I wanted to kindly ask if there’s any feedback or required changes for this PR.
All checks have passed, and I’d be happy to make any improvements needed to help with review.
Thanks for your time and for maintaining this great project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant