Skip to content

Comments

Add pattern printing (pyramid, inverted pyramid, diamond) [#13460]#13462

Open
sonianuj287 wants to merge 4 commits intoTheAlgorithms:masterfrom
sonianuj287:add-pattern-printing
Open

Add pattern printing (pyramid, inverted pyramid, diamond) [#13460]#13462
sonianuj287 wants to merge 4 commits intoTheAlgorithms:masterfrom
sonianuj287:add-pattern-printing

Conversation

@sonianuj287
Copy link

Summary

Added a beginner-friendly Python program that demonstrates loops, conditionals, and functions by printing:

  • Pyramid pattern
  • Inverted pyramid
  • Diamond pattern

Category

Beginner / Patterns

Features

  • Clean, modular functions
  • Proper docstrings with doctest examples
  • PEP8 compliant and type-annotated

Issue

Fixes #13460

@algorithms-keeper algorithms-keeper bot added the require descriptive names This PR needs descriptive function and/or variable names label Oct 21, 2025
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 21, 2025
@sonianuj287
Copy link
Author

Hi @darkstar @bit-man @spazm @horstjens , not sure whom to tag. but please review this PR. Thanks :)

@bit-man
Copy link
Contributor

bit-man commented Oct 21, 2025

@sonianuj287 not me for sure. Where did anyone get my username to ping me ?
Please let me know. Thanks

- Replace generic parameter 'n' with descriptive 'height'
- Update all function signatures and docstrings
- Maintain functionality while improving code readability
- All ruff checks pass
@algorithms-keeper algorithms-keeper bot removed the require descriptive names This PR needs descriptive function and/or variable names label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Pattern Printing Programs (Beginner Friendly)

2 participants