Add sorts/sleep_sort.py#13507
Closed
NghiemNgocDuc wants to merge 3 commits intoTheAlgorithms:masterfrom
Closed
Conversation
Add `sort/sleep_sort.py`: a novelty sleep-sort implementation with a simulated mode (safe for CI) and an optional real threaded mode. ### Files added - sort/sleep_sort.py ### Notes - File name is snake_case. - Includes doctests; tested with `python -m doctest -v sort/sleep_sort.py`. - Follows repository style. If this addresses an issue, add: `Fixes #<issue-number>`
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
sorts/sleep_sort.py
Outdated
| import time | ||
|
|
||
|
|
||
| def sleep_sort(a: List[int], simulate: bool = True, scale: float = 0.01) -> None: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
| results: List[int] = [] | ||
| lock = threading.Lock() | ||
|
|
||
| def worker(value: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/sleep_sort.py, please provide doctest for the function worker
sorts/sleep_sort.py
Outdated
| a[:] = results | ||
|
|
||
|
|
||
| def main() -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/sleep_sort.py, please provide doctest for the function main
Add sorts/sleep_sort.py: a novelty sleep-sort implementation with a simulated mode (safe for CI) and an optional real threaded mode. ### Files added - sorts/sleep_sort.py ### Notes - File name is snake_case. - Includes doctests; tested with python -m doctest -v sort/sleep_sort.py. - Follows repository style. If this addresses an issue, add: Fixes #<issue-number>
algorithms-keeper
bot
removed
the
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| results: List[int] = [] | ||
| lock = threading.Lock() | ||
|
|
||
| def worker(value: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/sleep_sort.py, please provide doctest for the function worker
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added a new and quirky sorting algorithm called Sleep Sort to the
sortsdirectory.This algorithm works by spawning a separate thread for each number and using time delays to order the output.
While not practical, it is an interesting demonstration of concurrency and timing-based sorting.
The implementation includes type hints, proper docstrings, and doctests as required by the contributing guidelines.
Checklist: