feat: Implement LRU Cache algorithm#13520
feat: Implement LRU Cache algorithm#13520maynkxx wants to merge 3 commits intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
the
require type hints
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
data_structures/lru_cache.py
Outdated
|
|
||
| class Node: | ||
| """A node in the doubly linked list.""" | ||
| def __init__(self, key: int, val: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
data_structures/lru_cache.py
Outdated
| >>> cache.get(4) | ||
| 4 | ||
| """ | ||
| def __init__(self, capacity: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
maynkxx
force-pushed
the
feat-lru-cache-implementation
branch
from
eef7e83 to
f69ec0e
Compare
algorithms-keeper
bot
removed
the
require type hints
maynkxx
force-pushed
the
feat-lru-cache-implementation
branch
from
1da5a15 to
106bf5f
Compare
algorithms-keeper
bot
added
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.head.next = self.tail | ||
| self.tail.prev = self.head | ||
|
|
||
| def _remove(self, node: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function _remove
| prev.next = nxt | ||
| nxt.prev = prev | ||
|
|
||
| def _add(self, node: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function _add
| self.head.next.prev = node | ||
| self.head.next = node | ||
|
|
||
| def get(self, key: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function get
| return node.val | ||
| return -1 | ||
|
|
||
| def put(self, key: int, value: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function put
maynkxx
force-pushed
the
feat-lru-cache-implementation
branch
from
61e0d3d to
106bf5f
Compare
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.head.next = self.tail | ||
| self.tail.prev = self.head | ||
|
|
||
| def _remove(self, node: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function _remove
| prev.next = nxt | ||
| nxt.prev = prev | ||
|
|
||
| def _add(self, node: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function _add
| self.head.next.prev = node | ||
| self.head.next = node | ||
|
|
||
| def get(self, key: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function get
| return node.val | ||
| return -1 | ||
|
|
||
| def put(self, key: int, value: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function put
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.head.next = self.tail | ||
| self.tail.prev = self.head | ||
|
|
||
| def _remove(self, node: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function _remove
| prev.next = nxt | ||
| nxt.prev = prev | ||
|
|
||
| def _add(self, node: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function _add
| self.head.next.prev = node | ||
| self.head.next = node | ||
|
|
||
| def get(self, key: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function get
| return node.val | ||
| return -1 | ||
|
|
||
| def put(self, key: int, value: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/lru_cache.py, please provide doctest for the function put
maynkxx
force-pushed
the
feat-lru-cache-implementation
branch
from
b28944c to
015842b
Compare
algorithms-keeper
bot
added
tests are failing
|
This is professional and polite. Hello team, all automated checks have passed. This is now ready for review whenever you have a moment. Thank you! |
maynkxx
force-pushed
the
feat-lru-cache-implementation
branch
from
f543fac to
23a434f
Compare
for more information, see https://pre-commit.ci
1 participant
Describe your change:
This pull request introduces an implementation of the LRU (Least Recently Used) Cache. It's a common caching strategy used to manage memory by evicting the least recently accessed items when the cache is full. The implementation uses a hash map for O(1) lookups and a doubly linked list to maintain the usage order.
Checklist:
data_structures).