Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,65 @@ | |||
| class Solution: | |||
| def generateMatrix(self, n: int) -> list[list[int]]: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/spiral_matrix.py, please provide doctest for the function generateMatrix
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: generateMatrix
Please provide descriptive name for the parameter: n
| value = 1 | ||
|
|
||
| # Define the boundaries for rows and columns | ||
| rowStart, rowEnd = 0, n - 1 |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: rowStart
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: rowEnd
|
|
||
| # Define the boundaries for rows and columns | ||
| rowStart, rowEnd = 0, n - 1 | ||
| colStart, colEnd = 0, n - 1 |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: colStart
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: colEnd
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,64 @@ | |||
| class Solution: | |||
| def generate_matrix(self, n: int) -> list[list[int]]: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/spiral_matrix.py, please provide doctest for the function generate_matrix
Please provide descriptive name for the parameter: n
| value = 1 | ||
|
|
||
| # Define the boundaries for rows and columns | ||
| rowStart, rowEnd = 0, n - 1 |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: rowStart
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: rowEnd
|
|
||
| # Define the boundaries for rows and columns | ||
| rowStart, rowEnd = 0, n - 1 | ||
| colStart, colEnd = 0, n - 1 |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: colStart
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: colEnd
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
require descriptive names
algorithms-keeper
bot
added
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,65 @@ | |||
| class Solution: | |||
| def generate_matrix(self, n: int) -> list[list[int]]: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/spiral_matrix.py, please provide doctest for the function generate_matrix
Please provide descriptive name for the parameter: n
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,67 @@ | |||
| class Solution: | |||
| def generate_matrix(self, n: int) -> list[list[int]]: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/spiral_matrix.py, please provide doctest for the function generate_matrix
Please provide descriptive name for the parameter: n
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
1 participant
Describe your change:
Checklist: