Add Manhattan and Minkowski distances to KNN with doctests#13555
Open
kdt523 wants to merge 4 commits intoTheAlgorithms:masterfrom
Open
Add Manhattan and Minkowski distances to KNN with doctests#13555kdt523 wants to merge 4 commits intoTheAlgorithms:masterfrom
kdt523 wants to merge 4 commits intoTheAlgorithms:masterfrom
Conversation
Author
|
Hi @TheAlgorithms/maintainers 👋 |
Author
|
Hi @TheAlgorithms/maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the K-Nearest Neighbours (KNN) implementation to support additional distance metrics while keeping Euclidean as the default.
What’s included:
Adds distance_metric parameter to KNN: 'euclidean' (default), 'manhattan', 'minkowski'
Adds p parameter for Minkowski (Lp) distance (validated p >= 1)
Implements _manhattan_distance and _minkowski_distance helpers
Updates classify() to use the selected metric
Stores training data as a list to avoid zip exhaustion on multiple calls
Moves the scikit-learn demo under main so importing the module has no extra dependency
Doctests: distances, classification across metrics, and error handling
Backward compatibility:
Existing code remains unchanged by default
(distance_metric='euclidean').
No documentation changes.
How to verify locally:
From the Python folder:
Doctests:
python -m doctest -v [k_nearest_neighbours.py]
Fixes #13546