Refactor t-SNE implementation and improve readability#13558
Open
technicalabinesh wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
Refactor t-SNE implementation and improve readability#13558technicalabinesh wants to merge 2 commits intoTheAlgorithms:masterfrom
technicalabinesh wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Incorrect pairwise distance broadcasting → Simplified using [:, np.newaxis] + [np.newaxis, :] for clarity; Wrong gradient update sign → Changed to + learning_rate * gradient (original was subtracting, causing collapse); Numerical instability → Added np.maximum(..., 1e-12) to avoid divide-by-zero; Improper normalization → Corrected affinity_matrix normalization so probabilities sum to 1; Docstring doctests rounding mismatch → Adjusted round() call and spacing for reproducible doctest results; Momentum correction → Improved gradient update rule for better convergence; Added np.round for printed output → Cleaner print of first 5 points.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect pairwise distance broadcasting → Simplified using [:, np.newaxis] + [np.newaxis, :] for clarity; Wrong gradient update sign → Changed to + learning_rate * gradient (original was subtracting, causing collapse); Numerical instability → Added np.maximum(..., 1e-12) to avoid divide-by-zero; Improper normalization → Corrected affinity_matrix normalization so probabilities sum to 1; Docstring doctests rounding mismatch → Adjusted round() call and spacing for reproducible doctest results; Momentum correction → Improved gradient update rule for better convergence; Added np.round for printed output → Cleaner print of first 5 points.
Describe your change:
Checklist: