Skip to content

Comments

Added ascii_to_char.py script (fixed checklist)#13608

Closed
siddheshsadarao wants to merge 4 commits intoTheAlgorithms:masterfrom
siddheshsadarao:master
Closed

Added ascii_to_char.py script (fixed checklist)#13608
siddheshsadarao wants to merge 4 commits intoTheAlgorithms:masterfrom
siddheshsadarao:master

Conversation

@siddheshsadarao
Copy link

This PR adds a script to convert ASCII values to characters.
Related issue: #13569

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have added my script in the correct folder (conversions/)
  • I have tested my code and it runs without errors

@algorithms-keeper algorithms-keeper bot added the require tests Tests [doctest/unittest/pytest] are required label Oct 19, 2025
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@@ -0,0 +1,7 @@
def ascii_to_char(ascii_val: int) -> str:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file conversions/ascii_to_char.py, please provide doctest for the function ascii_to_char

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 19, 2025
pre-commit-ci bot and others added 2 commits October 19, 2025 18:04
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Input: 65
Output: A
"""
def ascii_to_char(ascii_val: int) -> str:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file conversions/ascii_to_char.py, please provide doctest for the function ascii_to_char

@siddheshsadarao
Copy link
Author

@TheAlgorithms/maintainers
I have added the required docstring as requested.
Please review my PR for Hacktoberfest 😊

@siddheshsadarao siddheshsadarao closed this by deleting the head repository Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants