feat(searches): Add Floyd's Cycle-Finding Algorithm#13609
Open
AdityaK60 wants to merge 5 commits intoTheAlgorithms:masterfrom
Open
feat(searches): Add Floyd's Cycle-Finding Algorithm#13609AdityaK60 wants to merge 5 commits intoTheAlgorithms:masterfrom
AdityaK60 wants to merge 5 commits intoTheAlgorithms:masterfrom
Conversation
Signed-off-by: Aditya Kumar <aditya.kumar60@infosys.com>
algorithms-keeper
bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
searches/floyds_cycle_finding.py
Outdated
|
|
||
|
|
||
| def floyds_cycle_finding( | ||
| f: Callable[[Any], Any], x0: Any |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: f
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require descriptive names
AdityaK60
force-pushed
the
feat/add_floyds_cycle_finding_algorithm
branch
from
dbc879a to
77a3dd9
Compare
…rithm Signed-off-by: Aditya Kumar <aditya.kumar60@infosys.com>
AdityaK60
force-pushed
the
feat/add_floyds_cycle_finding_algorithm
branch
from
44efada to
0dd6821
Compare
for more information, see https://pre-commit.ci
AdityaK60
force-pushed
the
feat/add_floyds_cycle_finding_algorithm
branch
from
1ce9e37 to
1354285
Compare
Signed-off-by: Aditya Kumar <aditya.kumar60@infosys.com>
AdityaK60
force-pushed
the
feat/add_floyds_cycle_finding_algorithm
branch
from
1354285 to
19aca57
Compare
algorithms-keeper
bot
removed
the
tests are failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This pull request introduces an implementation of Floyd's Cycle-Finding Algorithm, also known as the "Tortoise and Hare" algorithm. This well-known algorithm is used to efficiently detect a cycle in a sequence of iterated values and also finds the cycle's starting point and length.
The file
floyds_cycle_finding.pyhas been added to thesearches/directory.Checklist: