Skip to content

Comments

Add Pollard's Rho for discrete logarithm #13656#13743

Closed
anshmittal2004 wants to merge 2 commits intoTheAlgorithms:masterfrom
anshmittal2004:add-pollard-dlp
Closed

Add Pollard's Rho for discrete logarithm #13656#13743
anshmittal2004 wants to merge 2 commits intoTheAlgorithms:masterfrom
anshmittal2004:add-pollard-dlp

Conversation

@anshmittal2004
Copy link

Closes #13656

Added Pollard's Rho algorithm for discrete logarithm in maths/.

  • Implements pollards_rho_discrete_log(g, h, p) as requested.
  • Uses Brent's cycle detection for O(√p) expected time.
  • Includes docstring with example (2^11 % 29 = 22) and complexity.
  • Handles small primes; probabilistic with retry on failure.
  • Added test cases for examples (g=2, h=22, p=29 and g=5, h=12, p=13).

[Hacktoberfest 2025 contribution]

Checklist

  • I have read the contribution guidelines.
  • The submitted code is in compliance with The Algorithms "Code quality" guidelines.
  • I have added a description to my changes.
  • I have added tests for the implementation.
  • I have added an explanation to my implementation. # Optional, add later if required
  • The code is not plagiarized and my own implementation.
  • The code is submitted to the correct issue.
  • I have run black to format the code.
  • I have run mypy to check for type hints.
  • I have read the README and the DIRECTORY and the submitted code is not duplicated.

@algorithms-keeper algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required labels Oct 24, 2025
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

from typing import Optional


def pollards_rho_discrete_log(g: int, h: int, p: int) -> Optional[int]:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file maths/pollard_rho_discrete_log.py, please provide doctest for the function pollards_rho_discrete_log

Please provide descriptive name for the parameter: g

Please provide descriptive name for the parameter: h

Please provide descriptive name for the parameter: p


# Function to compute discrete log candidate using baby-step giant-step on subgroup if needed
# But for full Rho, we use tortoise-hare
def f(x: int, y: int) -> int:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the function: f

As there is no test file in this pull request nor any test function or class in the file maths/pollard_rho_discrete_log.py, please provide doctest for the function f

Please provide descriptive name for the parameter: x

Please provide descriptive name for the parameter: y

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Pollard’s Rho algorithm for discrete logarithm

1 participant