Add Pollard's Rho for discrete logarithm #13656#13743
Add Pollard's Rho for discrete logarithm #13656#13743anshmittal2004 wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from typing import Optional | ||
|
|
||
|
|
||
| def pollards_rho_discrete_log(g: int, h: int, p: int) -> Optional[int]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/pollard_rho_discrete_log.py, please provide doctest for the function pollards_rho_discrete_log
Please provide descriptive name for the parameter: g
Please provide descriptive name for the parameter: h
Please provide descriptive name for the parameter: p
|
|
||
| # Function to compute discrete log candidate using baby-step giant-step on subgroup if needed | ||
| # But for full Rho, we use tortoise-hare | ||
| def f(x: int, y: int) -> int: |
There was a problem hiding this comment.
Please provide descriptive name for the function: f
As there is no test file in this pull request nor any test function or class in the file maths/pollard_rho_discrete_log.py, please provide doctest for the function f
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
for more information, see https://pre-commit.ci
Closes #13656
Added Pollard's Rho algorithm for discrete logarithm in
maths/.pollards_rho_discrete_log(g, h, p)as requested.[Hacktoberfest 2025 contribution]
Checklist
blackto format the code.mypyto check for type hints.