build binary-tree using traversals#13768
build binary-tree using traversals#13768Sai-Adithya-M wants to merge 5 commits intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,105 @@ | |||
| # Binary Tree Node class | |||
| class Node: | |||
| def __init__(self, data): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: data
|
|
||
|
|
||
| # Normal inorder traversal | ||
| def inorder(root, out): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function inorder
Please provide return type hint for the function: inorder. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: root
Please provide type hint for the parameter: out
|
|
||
|
|
||
| # === Build tree using PREORDER + INORDER === | ||
| def build_tree_from_pre(preorder, pre_start, pre_end, |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_from_pre
Please provide return type hint for the function: build_tree_from_pre. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: preorder
Please provide type hint for the parameter: pre_start
Please provide type hint for the parameter: pre_end
|
|
||
| # === Build tree using PREORDER + INORDER === | ||
| def build_tree_from_pre(preorder, pre_start, pre_end, | ||
| inorder_seq, in_start, in_end, in_map): |
There was a problem hiding this comment.
Please provide type hint for the parameter: inorder_seq
Please provide type hint for the parameter: in_start
Please provide type hint for the parameter: in_end
Please provide type hint for the parameter: in_map
| return root | ||
|
|
||
|
|
||
| def build_tree_pre(inorder_seq, preorder_seq): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_pre
Please provide return type hint for the function: build_tree_pre. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: inorder_seq
Please provide type hint for the parameter: preorder_seq
|
|
||
|
|
||
| # === Build tree using POSTORDER + INORDER === | ||
| def build_tree_from_post(postorder, post_start, post_end, |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_from_post
Please provide return type hint for the function: build_tree_from_post. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: postorder
Please provide type hint for the parameter: post_start
Please provide type hint for the parameter: post_end
|
|
||
| # === Build tree using POSTORDER + INORDER === | ||
| def build_tree_from_post(postorder, post_start, post_end, | ||
| inorder_seq, in_start, in_end, in_map): |
There was a problem hiding this comment.
Please provide type hint for the parameter: inorder_seq
Please provide type hint for the parameter: in_start
Please provide type hint for the parameter: in_end
Please provide type hint for the parameter: in_map
| return root | ||
|
|
||
|
|
||
| def build_tree_post(inorder_seq, postorder_seq): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_post
Please provide return type hint for the function: build_tree_post. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: inorder_seq
Please provide type hint for the parameter: postorder_seq
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| return inorder_traversal(root.left) + [root.data] + inorder_traversal(root.right) | ||
|
|
||
|
|
||
| def _build_tree_from_preorder( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function _build_tree_from_preorder
| ) | ||
|
|
||
|
|
||
| def _build_tree_from_postorder( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function _build_tree_from_postorder
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.parent: Node | None = None | ||
|
|
||
|
|
||
| def inorder_traversal(root: Node | None, out: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function inorder_traversal
| inorder_traversal(root.right, out) | ||
|
|
||
|
|
||
| def _build_tree_from_preorder( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function _build_tree_from_preorder
| return root | ||
|
|
||
|
|
||
| def build_tree_from_preorder(inorder: list[int], preorder: list[int]) -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_from_preorder
| return root | ||
|
|
||
|
|
||
| def build_tree_from_postorder(inorder: list[int], postorder: list[int]) -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_from_postorder
for more information, see https://pre-commit.ci
1 participant
Describe your change:
With only one traversal given,we cannot build a tree.We need atleast two of the traversals to get a full tree(i.e. given two traversals a unique binary-tree can be constructed).Here, two types(inorder+preorder;inorder+postorder) was done.
We used recursion technique to build it.
Checklist: