feat: added unified tree traversal to compute preorder, inorder, and postorder in one pass#13773
feat: added unified tree traversal to compute preorder, inorder, and postorder in one pass#13773TenFinges wants to merge 4 commits intoTheAlgorithms:masterfrom
Conversation
…versals in one traversal.
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Reference: https://en.wikipedia.org/wiki/Binary_tree | ||
| """ | ||
|
|
||
| def __init__(self, data: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.right: Optional[Node] = None | ||
|
|
||
|
|
||
| def all_traversals(root: Optional[Node]) -> Tuple[List[int], List[int], List[int]]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/all_traversals_one_pass.py, please provide doctest for the function all_traversals
| return preorder, inorder, postorder | ||
|
|
||
|
|
||
| def build_sample_tree() -> Node: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/all_traversals_one_pass.py, please provide doctest for the function build_sample_tree
for more information, see https://pre-commit.ci
…versals in one traversal.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Reference: https://en.wikipedia.org/wiki/Binary_tree | ||
| """ | ||
|
|
||
| def __init__(self, data: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.right: Node | None = None | ||
|
|
||
|
|
||
| def all_traversals(root: Node | None) -> tuple[list[int], list[int], list[int]]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/all_traversals_one_pass.py, please provide doctest for the function all_traversals
| return preorder, inorder, postorder | ||
|
|
||
|
|
||
| def build_sample_tree() -> Node: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/all_traversals_one_pass.py, please provide doctest for the function build_sample_tree
algorithms-keeper
bot
added
tests are failing
1 participant
Describe your change:
Checklist: